Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(attachment) - more option button invoke correctly action on space/enter #1452

Merged
kolaps33 merged 6 commits into from
Jun 17, 2019
Merged

fix(attachment) - more option button invoke correctly action on space/enter #1452

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad74ccb
ensure that more option button or element has action on space/enter
mituron Jun 4, 2019
51cd207
rely on event target
mituron Jun 5, 2019
38279b7
merge with latest master
mituron Jun 13, 2019
6a6fdaf
removing code commented out
mituron Jun 13, 2019
3d5a44b
removing not used code
mituron Jun 13, 2019
4bab11d
Merge branch 'master' into mituron/1450-more-option-button
kolaps33 Jun 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/react/src/components/Attachment/Attachment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,10 @@ class Attachment extends UIComponent<WithAsProp<AttachmentProps>, AttachmentStat
}

performClick = e => {
e.stopPropagation()
this.handleClick(e)
if (e.currentTarget === e.target) {
Copy link
Contributor

@jurokapsiar jurokapsiar Jun 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on agreement with @layershifter and @miroslavstastny this is ok for now, but it shows a bigger issue we have related to click handling of components that have parent/child clickable elements, especially if the elements trigger click on keyboard events (button, a)

This might help move the logic to behaviors: #1502

e.stopPropagation()
this.handleClick(e)
}
}

handleClick = (e: React.SyntheticEvent) => {
Expand Down