Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Icon): Icons for screen sharing control in the calling screen #1490

Merged
kuzhelov merged 5 commits into from
Jun 12, 2019
Merged

feat(Icon): Icons for screen sharing control in the calling screen #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
874153a
#1485 Icons for screen sharing control in the calling screen
jay-howe Jun 11, 2019
ac4d5b3
Fix the view box
jay-howe Jun 12, 2019
016d838
Merge branch 'master' of https://github.com/stardust-ui/react into ja…
jay-howe Jun 12, 2019
3dea6a6
Add a changelog entry
jay-howe Jun 12, 2019
5c30079
Fix the changelog entry
jay-howe Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Improve accessibility for `Checkbox` @jurokapsiar ([1479](https://github.com/stardust-ui/react/pull/1479))
- Add `unstable_pinned` prop to `Popup` and `Dropdown` components @Bugaa92 ([#1471](https://github.com/stardust-ui/react/pull/1471))
- Add `Tooltip` component @mnajdova ([#1455](https://github.com/stardust-ui/react/pull/1455))
- Add 'call-control-release' and 'call-control-request' icon to Teams theme @jay-howe ([#1490](https://github.com/stardust-ui/react/pull/1490))

### Fixes
- Fix click handling on focus for `action` slot in `Attachment` component @Bugaa92 ([#1444](https://github.com/stardust-ui/react/pull/1444))
Expand Down
27 changes: 27 additions & 0 deletions .../react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-control-release.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import * as React from 'react'
import { TeamsProcessedSvgIconSpec } from '../types'

export default {
icon: ({ classes }) => (
<svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}>
<path
d="M23,11.0816984l0.8432999-0.8432999
C23.9435902,10.4396133,24,10.6665344,24,10.9066315v6.4375h-0.0038681c-0.030756,0.246645-0.2411556,0.4375-0.4961319,0.4375
s-0.4653759-0.190855-0.4961319-0.4375H23V11.0816984z M19.5108528,10.4066315H9.5c-0.2761421,0-0.5,0.2238569-0.5,0.5v9
c0,0.2761421,0.2238579,0.5,0.5,0.5h0.0108538l-0.7850342,0.7850342C8.2908373,20.9290428,8,20.4518013,8,19.9066315v-9
c0-0.8284273,0.6715727-1.5,1.5-1.5h11.0108528L19.5108528,10.4066315z M16.1707726,13.7467136L14.875,15.0424852v-0.7671566
c0-0.1745424,0.0626001-0.343524,0.1768417-0.4773626c0.2688255-0.3149405,0.7470818-0.3565264,1.0682163-0.0928869
L16.1707726,13.7467136z M18.4575882,15.6241102l2.0208569,1.6590528C20.6505604,17.4244633,20.75,17.6332836,20.75,17.8534126
c0,0.4107227-0.3395042,0.743679-0.7583065,0.743679h-1.3556843l1.8609123,3.6433411
c0.2237434,0.4380474,0.0456886,0.9710884-0.3989677,1.1943989c-0.0017738,0.0008907-0.0035477,0.0017738-0.0053253,0.0026512
c-0.4420586,0.2183704-0.9809208,0.0439472-1.2035866-0.3895817l-1.8720703-3.6449432l-0.781147,1.0024796
c-0.1434631,0.1841164-0.3662395,0.2921276-0.6025181,0.2921276c-0.4188004,0-0.7583065-0.3329563-0.7583065-0.743681v-0.7471848
L18.4575882,15.6241102z M23.3751297,8.6148157c0.1952629,0.195262,0.1952629,0.5118446,0,0.7071066L9.3213835,23.3756695
c-0.195262,0.1952629-0.5118446,0.1952629-0.7071066,0s-0.195262-0.5118446,0-0.7071075L22.6680241,8.6148157
C22.8632851,8.4195538,23.1798687,8.4195538,23.3751297,8.6148157z"
/>
</svg>
),
styles: {},
exportedAs: 'call-control-release',
} as TeamsProcessedSvgIconSpec
24 changes: 24 additions & 0 deletions .../react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-control-request.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import * as React from 'react'
import { TeamsProcessedSvgIconSpec } from '../types'

export default {
icon: ({ classes }) => (
<svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}>
<path
d="M12.125,20.4066315c0.2761421,0,0.5,0.2238579,0.5,0.5s-0.2238579,0.5-0.5,0.5H9.5
c-0.8284273,0-1.5-0.6715736-1.5-1.5v-9c0-0.8284273,0.6715727-1.5,1.5-1.5h13c0.8284264,0,1.5,0.6715727,1.5,1.5v6.4375h-0.0038681
c-0.030756,0.246645-0.2411556,0.4375-0.4961319,0.4375s-0.4653759-0.190855-0.4961319-0.4375H23v-6.4375
c0-0.2761431-0.2238579-0.5-0.5-0.5h-13c-0.2761421,0-0.5,0.2238569-0.5,0.5v9c0,0.2761421,0.2238579,0.5,0.5,0.5H12.125z
M14.875,14.2753286c0-0.1745424,0.0626001-0.343524,0.1768417-0.4773626
c0.2688246-0.3149405,0.7470818-0.3565264,1.0682163-0.0928869l4.358387,3.578084
C20.6505585,17.4244633,20.75,17.6332836,20.75,17.8534126c0,0.4107227-0.3395042,0.743679-0.7583065,0.743679h-1.3556843
l1.8609123,3.6433411c0.2237434,0.4380474,0.0456886,0.9710884-0.3989677,1.1943989
c-0.0017738,0.0008907-0.0035477,0.0017738-0.0053253,0.0026512c-0.4420586,0.2183704-0.9809208,0.0439472-1.2035866-0.3895817
l-1.8720703-3.6449432l-0.781147,1.0024796c-0.143465,0.1841164-0.3662395,0.2921276-0.6025181,0.2921276
c-0.4188013,0-0.7583065-0.3329563-0.7583065-0.743681V14.2753286z"
/>
</svg>
),
styles: {},
exportedAs: 'call-control-request',
} as TeamsProcessedSvgIconSpec
4 changes: 4 additions & 0 deletions packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/index-new.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,8 @@ import processedIcons_callincomingvideo from './icons-call-incoming-video'
import processedIcons_callhold from './icons-call-hold'
import processedIcons_callend from './icons-call-end'
import processedIcons_calldialpad from './icons-call-dialpad'
import processedIcons_callcontrolrelease from './icons-call-control-release'
import processedIcons_callcontrolrequest from './icons-call-control-request'
import processedIcons_callcontrolstoppresentingnew from './icons-call-control-stop-presenting-new'
import processedIcons_callcontrolpresentnew from './icons-call-control-present-new'
import processedIcons_callblocked from './icons-call-blocked'
Expand Down Expand Up @@ -565,6 +567,8 @@ export default {
processedIcons_callhold,
processedIcons_callend,
processedIcons_calldialpad,
processedIcons_callcontrolrelease,
processedIcons_callcontrolrequest,
processedIcons_callcontrolstoppresentingnew,
processedIcons_callcontrolpresentnew,
processedIcons_callblocked,
Expand Down
4 changes: 4 additions & 0 deletions packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,8 @@ import processedIcons_callincomingvideo from './icons-call-incoming-video'
import processedIcons_callhold from './icons-call-hold'
import processedIcons_callend from './icons-call-end'
import processedIcons_calldialpad from './icons-call-dialpad'
import processedIcons_callcontrolrelease from './icons-call-control-release'
import processedIcons_callcontrolrequest from './icons-call-control-request'
import processedIcons_callcontrolstoppresentingnew from './icons-call-control-stop-presenting-new'
import processedIcons_callcontrolpresentnew from './icons-call-control-present-new'
import processedIcons_callblocked from './icons-call-blocked'
Expand Down Expand Up @@ -572,6 +574,8 @@ export default {
processedIcons_callhold,
processedIcons_callend,
processedIcons_calldialpad,
processedIcons_callcontrolrelease,
processedIcons_callcontrolrequest,
processedIcons_callcontrolstoppresentingnew,
processedIcons_callcontrolpresentnew,
processedIcons_callblocked,
Expand Down
27 changes: 27 additions & 0 deletions packages/react/src/themes/teams/components/Icon/svg/icons/callControlRelease.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import * as React from 'react'
import { TeamsProcessedSvgIconSpec } from '../types'

export default {
icon: ({ classes }) => (
<svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}>
<path
d="M23,11.0816984l0.8432999-0.8432999
C23.9435902,10.4396133,24,10.6665344,24,10.9066315v6.4375h-0.0038681c-0.030756,0.246645-0.2411556,0.4375-0.4961319,0.4375
s-0.4653759-0.190855-0.4961319-0.4375H23V11.0816984z M19.5108528,10.4066315H9.5c-0.2761421,0-0.5,0.2238569-0.5,0.5v9
c0,0.2761421,0.2238579,0.5,0.5,0.5h0.0108538l-0.7850342,0.7850342C8.2908373,20.9290428,8,20.4518013,8,19.9066315v-9
c0-0.8284273,0.6715727-1.5,1.5-1.5h11.0108528L19.5108528,10.4066315z M16.1707726,13.7467136L14.875,15.0424852v-0.7671566
c0-0.1745424,0.0626001-0.343524,0.1768417-0.4773626c0.2688255-0.3149405,0.7470818-0.3565264,1.0682163-0.0928869
L16.1707726,13.7467136z M18.4575882,15.6241102l2.0208569,1.6590528C20.6505604,17.4244633,20.75,17.6332836,20.75,17.8534126
c0,0.4107227-0.3395042,0.743679-0.7583065,0.743679h-1.3556843l1.8609123,3.6433411
c0.2237434,0.4380474,0.0456886,0.9710884-0.3989677,1.1943989c-0.0017738,0.0008907-0.0035477,0.0017738-0.0053253,0.0026512
c-0.4420586,0.2183704-0.9809208,0.0439472-1.2035866-0.3895817l-1.8720703-3.6449432l-0.781147,1.0024796
c-0.1434631,0.1841164-0.3662395,0.2921276-0.6025181,0.2921276c-0.4188004,0-0.7583065-0.3329563-0.7583065-0.743681v-0.7471848
L18.4575882,15.6241102z M23.3751297,8.6148157c0.1952629,0.195262,0.1952629,0.5118446,0,0.7071066L9.3213835,23.3756695
c-0.195262,0.1952629-0.5118446,0.1952629-0.7071066,0s-0.195262-0.5118446,0-0.7071075L22.6680241,8.6148157
C22.8632851,8.4195538,23.1798687,8.4195538,23.3751297,8.6148157z"
/>
</svg>
),
styles: {},
exportedAs: 'call-control-release',
} as TeamsProcessedSvgIconSpec
24 changes: 24 additions & 0 deletions packages/react/src/themes/teams/components/Icon/svg/icons/callControlRequest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import * as React from 'react'
import { TeamsProcessedSvgIconSpec } from '../types'

export default {
icon: ({ classes }) => (
<svg role="presentation" focusable="false" viewBox="8 8 16 16" className={classes.svg}>
<path
d="M12.125,20.4066315c0.2761421,0,0.5,0.2238579,0.5,0.5s-0.2238579,0.5-0.5,0.5H9.5
c-0.8284273,0-1.5-0.6715736-1.5-1.5v-9c0-0.8284273,0.6715727-1.5,1.5-1.5h13c0.8284264,0,1.5,0.6715727,1.5,1.5v6.4375h-0.0038681
c-0.030756,0.246645-0.2411556,0.4375-0.4961319,0.4375s-0.4653759-0.190855-0.4961319-0.4375H23v-6.4375
c0-0.2761431-0.2238579-0.5-0.5-0.5h-13c-0.2761421,0-0.5,0.2238569-0.5,0.5v9c0,0.2761421,0.2238579,0.5,0.5,0.5H12.125z
M14.875,14.2753286c0-0.1745424,0.0626001-0.343524,0.1768417-0.4773626
c0.2688246-0.3149405,0.7470818-0.3565264,1.0682163-0.0928869l4.358387,3.578084
C20.6505585,17.4244633,20.75,17.6332836,20.75,17.8534126c0,0.4107227-0.3395042,0.743679-0.7583065,0.743679h-1.3556843
l1.8609123,3.6433411c0.2237434,0.4380474,0.0456886,0.9710884-0.3989677,1.1943989
c-0.0017738,0.0008907-0.0035477,0.0017738-0.0053253,0.0026512c-0.4420586,0.2183704-0.9809208,0.0439472-1.2035866-0.3895817
l-1.8720703-3.6449432l-0.781147,1.0024796c-0.143465,0.1841164-0.3662395,0.2921276-0.6025181,0.2921276
c-0.4188013,0-0.7583065-0.3329563-0.7583065-0.743681V14.2753286z"
/>
</svg>
),
styles: {},
exportedAs: 'call-control-request',
} as TeamsProcessedSvgIconSpec
4 changes: 4 additions & 0 deletions packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import bullets from './bullets'
import calendar from './calendar'
import call from './call'
import callParking from './callParking'
import callControlRelease from './callControlRelease'
Copy link
Contributor

@kuzhelov kuzhelov Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets maintain alphabetical order, to simplify search scenarios

Copy link
Contributor Author

@jay-howe jay-howe Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am keeping release and request as a group (viewer) as they are most closely related. The other call-control-xxx icons are a different group (sender)

Copy link
Contributor Author

@jay-howe jay-howe Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have grouped them by concepts as opposed to lexical order.

Copy link
Contributor Author

@jay-howe jay-howe Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing list is already out of order. Do you want me to fix it?

Copy link
Contributor

@kuzhelov kuzhelov Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, lets stick to the order pattern already established - thank you for clarification!

import callControlRequest from './callControlRequest'
import callControlPresentNew from './callControlPresentNew'
import callControlStopPresentingNew from './callControlStopPresentingNew'
import callControlShare from './callControlShare'
Expand Down Expand Up @@ -150,6 +152,8 @@ export default {
'call-parking': callParking,
'call-video': callVideo,
'call-video-off': callVideoOff,
'call-control-release': callControlRelease,
Copy link
Contributor

@kuzhelov kuzhelov Jun 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets ensure those are pasted in alphabetical order to the set of other ones

Copy link
Contributor

@kuzhelov kuzhelov Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed to keep 'concepts-based' order

'call-control-request': callControlRequest,
'call-control-close-tray': callControlCloseTray,
'call-control-present-new': callControlPresentNew,
'call-control-stop-presenting-new': callControlStopPresentingNew,
Expand Down