Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Provider): add target prop#1500

Closed
layershifter wants to merge 1 commit intomasterfrom
feat/provide-target
Closed

feat(Provider): add target prop#1500
layershifter wants to merge 1 commit intomasterfrom
feat/provide-target

Conversation

@layershifter
Copy link
Member

This PR is a part of #1252. Only to unblock usage, no changelog. Will be updated with real implementation later.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jun 14, 2019

Codecov Report

Merging #1500 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1500   +/-   ##
=======================================
  Coverage   73.44%   73.44%           
=======================================
  Files         822      822           
  Lines        6190     6190           
  Branches     1776     1795   +19     
=======================================
  Hits         4546     4546           
  Misses       1639     1639           
  Partials        5        5
Impacted Files Coverage Δ
...ackages/react/src/components/Provider/Provider.tsx 95.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23622eb...538228c. Read the comment docs.

@kuzhelov
Copy link
Contributor

why we will introduce this prop without real implementation? I mean, if this prop is necessary for the client, for some emulation scenarios, client may just wrap our Provider component with the additional prop (target) provided. This should unblock usage, which is the goal of this PR

@layershifter layershifter deleted the feat/provide-target branch July 2, 2019 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants