This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): icons in docs not rendered properly#1625
Closed
lucivpav wants to merge 29 commits intomicrosoft:masterfrom
Closed
fix(docs): icons in docs not rendered properly#1625lucivpav wants to merge 29 commits intomicrosoft:masterfrom
lucivpav wants to merge 29 commits intomicrosoft:masterfrom
Conversation
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 71.49% 71.28% -0.21%
==========================================
Files 846 846
Lines 6945 6938 -7
Branches 2002 1982 -20
==========================================
- Hits 4965 4946 -19
- Misses 1974 1986 +12
Partials 6 6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
=========================================
Coverage ? 70.07%
=========================================
Files ? 867
Lines ? 7429
Branches ? 2161
=========================================
Hits ? 5206
Misses ? 2215
Partials ? 8Continue to review full report at Codecov.
|
kuzhelov
reviewed
Jul 19, 2019
lucivpav
added
ready for merge
and removed
needs author feedback
miroslavstastny
approved these changes
Aug 13, 2019
Contributor
Author
|
This was fixed by PR #1764. Closing this as it is no longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the outdated code snippets in theming section of docs. The icon colors were not set properly and the output did not match user's expectation. Relevant issue with error description: #1591.
Before:
After:
