Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(Popup): show on contextmenu (replacement to fix the screener issue)#1685

Closed
jurokapsiar wants to merge 1 commit intomasterfrom
jukapsia/popup-context2
Closed

feat(Popup): show on contextmenu (replacement to fix the screener issue)#1685
jurokapsiar wants to merge 1 commit intomasterfrom
jukapsia/popup-context2

Conversation

@jurokapsiar
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1685 into master will decrease coverage by 0.07%.
The diff coverage is 59.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
- Coverage   71.29%   71.21%   -0.08%     
==========================================
  Files         854      856       +2     
  Lines        7047     7088      +41     
  Branches     2029     2026       -3     
==========================================
+ Hits         5024     5048      +24     
- Misses       2017     2034      +17     
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/lib/positioner/Popper.tsx 89.58% <100%> (+0.45%) ⬆️
packages/react/src/lib/isRightClick.ts 100% <100%> (ø)
...omponents/Popup/createReferenceFromContextClick.ts 12.5% <12.5%> (ø)
packages/react/src/components/Popup/Popup.tsx 65.71% <57.57%> (-0.74%) ⬇️
...lib/accessibility/Behaviors/Popup/popupBehavior.ts 93.75% <85.71%> (-2.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e8547a...8dd38f0. Read the comment docs.

@jurokapsiar
Copy link
Contributor Author

abondoning

@jurokapsiar jurokapsiar deleted the jukapsia/popup-context2 branch July 19, 2019 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant