feat(Chat): add Control messages prototype#1687
Conversation
-added screener steps
-fixed steps
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1687 +/- ##
==========================================
- Coverage 69.99% 69.97% -0.02%
==========================================
Files 868 868
Lines 7323 7325 +2
Branches 2117 2117
==========================================
Hits 5126 5126
- Misses 2191 2193 +2
Partials 6 6
Continue to review full report at Codecov.
|
-extracted behaviors
mnajdova
changed the title
| } | ||
| }, | ||
| content: ( | ||
| <Tree |
There was a problem hiding this comment.
Looking at the chat example, it was not clear to me that this is actually an expansible tree.
There was a problem hiding this comment.
The styling are not implemented for this prototype, we are focusing only on the behavior and whether everything works as expected
| }, | ||
| } | ||
|
|
||
| const treeItems = [ |
There was a problem hiding this comment.
These two items are almost identical. How about extracting the code into a function?
There was a problem hiding this comment.
will refactor it once we decide on the final implementation
|
Closing as this has seen no activity for awhile. Please reopen if still relevant. Thanks! |
4 participants
This PR adds prototype for the Control messages that can be used in the Chat. They are based on the Tree* components, with some custom overrides on the behaviors. The styling is not done currently, we want to focus on the accessibility first and test all scenarios.