Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

[IGNORE] release: 0.34.2#1692

Closed
layershifter wants to merge 4 commits intomasterfrom
chore/0.34.2
Closed

[IGNORE] release: 0.34.2#1692
layershifter wants to merge 4 commits intomasterfrom
chore/0.34.2

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jul 19, 2019

0.34.2

Release that contains only bug-fixes.

Includes

* fix(Checkbox): fix gap styling in RTL

* polish styles

* add CHANGELOG and new screener test

* apply review comment

(cherry picked from commit c965ce6)
@DustyTheBot
Copy link
Collaborator

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #1692 into master will increase coverage by 0.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   71.16%   71.42%   +0.26%     
==========================================
  Files         857      848       -9     
  Lines        7102     6943     -159     
  Branches     2032     2008      -24     
==========================================
- Hits         5054     4959      -95     
+ Misses       2042     1978      -64     
  Partials        6        6
Impacted Files Coverage Δ
...t/src/themes/teams/components/Popup/popupStyles.ts 25% <0%> (-8.34%) ⬇️
.../themes/base/components/Checkbox/checkboxStyles.ts 6.25% <0%> (ø) ⬆️
packages/react/src/components/Chat/Chat.tsx 62.5% <0%> (-8.93%) ⬇️
...hemes/teams/components/Popup/popupContentStyles.ts 16.66% <0%> (-3.34%) ⬇️
...ages/react/test/specs/behaviors/testDefinitions.ts 91.46% <0%> (-1.63%) ⬇️
packages/react-proptypes/src/index.ts 33.8% <0%> (-0.47%) ⬇️
...ackages/react/src/components/Dropdown/Dropdown.tsx 88.1% <0%> (-0.12%) ⬇️
packages/react/src/lib/factories.ts 94.11% <0%> (-0.09%) ⬇️
...src/themes/teams/components/Dialog/dialogStyles.ts 0% <0%> (ø) ⬆️
...ckages/react/src/components/Button/ButtonGroup.tsx 94.11% <0%> (ø) ⬆️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c965ce6...94517d4. Read the comment docs.

* fix(Popup): fix broken background with pointing and FocusTrap

* update CHANGELOG

* fix for render callback

* fix comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants