Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Chore: release 0.34.3#1710

Closed
layershifter wants to merge 8 commits intomasterfrom
chore/0.34.3
Closed

Chore: release 0.34.3#1710
layershifter wants to merge 8 commits intomasterfrom
chore/0.34.3

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jul 23, 2019

0.34.2

Release that contains only bug-fixes.

Includes

* fix(Checkbox): fix gap styling in RTL

* polish styles

* add CHANGELOG and new screener test

* apply review comment

(cherry picked from commit c965ce6)
* fix(Popup): fix broken background with pointing and FocusTrap

* update CHANGELOG

* fix for render callback

* fix comment
* add nesting registry

* wip

* add prototype

* add E2E tests

* remove console.log

* add changelog entry

* fix dangerjs issue

* Update e2e/tests/dialogInPopup-test.ts

Co-Authored-By: Marija Najdova <mnajdova@gmail.com>

* Update e2e/tests/dialogInDialog-test.ts

Co-Authored-By: Marija Najdova <mnajdova@gmail.com>

* update test header

* use boundingBox

* update method

(cherry picked from commit 5afe10c)
@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #1710 into master will increase coverage by 0.24%.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1710      +/-   ##
==========================================
+ Coverage   71.17%   71.41%   +0.24%     
==========================================
  Files         858      848      -10     
  Lines        7111     6948     -163     
  Branches     2034     2009      -25     
==========================================
- Hits         5061     4962      -99     
+ Misses       2044     1980      -64     
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/components/Portal/Portal.tsx 100% <ø> (ø) ⬆️
...t/src/themes/teams/components/Popup/popupStyles.ts 25% <0%> (-8.34%) ⬇️
.../themes/base/components/Checkbox/checkboxStyles.ts 6.25% <0%> (ø) ⬆️
packages/react/src/components/Popup/Popup.tsx 68.15% <100%> (+2.43%) ⬆️
packages/react/src/components/Dialog/Dialog.tsx 34.88% <45.45%> (ø) ⬆️
packages/react/src/components/Chat/Chat.tsx 62.5% <0%> (-8.93%) ⬇️
...hemes/teams/components/Popup/popupContentStyles.ts 16.66% <0%> (-3.34%) ⬇️
...ages/react/test/specs/behaviors/testDefinitions.ts 91.46% <0%> (-1.63%) ⬇️
packages/react-proptypes/src/index.ts 33.8% <0%> (-0.47%) ⬇️
packages/react/src/lib/factories.ts 94.11% <0%> (-0.33%) ⬇️
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afe10c...65eba30. Read the comment docs.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Jul 23, 2019

Fails
🚫 All of your entries in CHANGELOG.md should be in the **Unreleased** section!
Warnings
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies in packages/react/package.json

package before after
@stardust-ui/react-component-nesting-registry ^0.34.0 ^0.34.3

Generated by 🚫 dangerJS

@layershifter layershifter deleted the chore/0.34.3 branch July 25, 2019 16:38
@layershifter layershifter restored the chore/0.34.3 branch August 2, 2019 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants