This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Closed
Conversation
* fix(Checkbox): fix gap styling in RTL * polish styles * add CHANGELOG and new screener test * apply review comment (cherry picked from commit c965ce6)
* fix(Popup): fix broken background with pointing and FocusTrap * update CHANGELOG * fix for render callback * fix comment
* add nesting registry * wip * add prototype * add E2E tests * remove console.log * add changelog entry * fix dangerjs issue * Update e2e/tests/dialogInPopup-test.ts Co-Authored-By: Marija Najdova <mnajdova@gmail.com> * Update e2e/tests/dialogInDialog-test.ts Co-Authored-By: Marija Najdova <mnajdova@gmail.com> * update test header * use boundingBox * update method (cherry picked from commit 5afe10c)
Codecov Report
@@ Coverage Diff @@
## master #1710 +/- ##
==========================================
+ Coverage 71.17% 71.41% +0.24%
==========================================
Files 858 848 -10
Lines 7111 6948 -163
Branches 2034 2009 -25
==========================================
- Hits 5061 4962 -99
+ Misses 2044 1980 -64
Partials 6 6
Continue to review full report at Codecov.
|
Collaborator
Changed dependencies in
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.34.2
Release that contains only bug-fixes.
Includes