This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
Collaborator
Changed dependencies are detected.Changed dependencies in
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
=========================================
+ Coverage 69.84% 69.9% +0.06%
=========================================
Files 888 888
Lines 7762 7775 +13
Branches 2269 2244 -25
=========================================
+ Hits 5421 5435 +14
+ Misses 2331 2330 -1
Partials 10 10
Continue to review full report at Codecov.
|
Member
Author
|
layershifter
commented
Aug 21, 2019
miroslavstastny
approved these changes
Aug 30, 2019
Member
There was a problem hiding this comment.
please add a uni test to document the function
87598b1 to
29f3c4e
Compare
29f3c4e to
e38ce5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1686.
This PR moves us back to production Fela 🎉
Please check
mergeRenderers()function, don't have better ideas 😿 It's required because forked Fela managed this on its side, while production allows only to pass your own renderer.