Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore: switch back to Fela#1743

Merged
layershifter merged 1 commit intomasterfrom
chore/fela-switch-back
Sep 4, 2019
Merged

chore: switch back to Fela#1743
layershifter merged 1 commit intomasterfrom
chore/fela-switch-back

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Aug 1, 2019

Fixes #1686.

This PR moves us back to production Fela 🎉

Please check mergeRenderers() function, don't have better ideas 😿 It's required because forked Fela managed this on its side, while production allows only to pass your own renderer.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Aug 1, 2019

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
fela-plugin-embedded ^10.5.0 ^10.6.1
fela-plugin-fallback-value ^10.5.0 ^10.6.1
fela-plugin-placeholder-prefixer ^10.5.0 ^10.6.1
fela-plugin-prefixer ^10.5.0 ^10.6.1
fela-plugin-rtl ^10.5.0 ^10.6.1
fela - ^10.6.1
react-fela - ^10.6.1

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #1743 into master will increase coverage by 0.06%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1743      +/-   ##
=========================================
+ Coverage   69.84%   69.9%   +0.06%     
=========================================
  Files         888     888              
  Lines        7762    7775      +13     
  Branches     2269    2244      -25     
=========================================
+ Hits         5421    5435      +14     
+ Misses       2331    2330       -1     
  Partials       10      10
Impacted Files Coverage Δ
packages/react/src/lib/felaFocusVisibleEnhancer.ts 100% <ø> (ø) ⬆️
packages/react/test/utils/withProvider.tsx 100% <ø> (ø) ⬆️
...ckages/react/src/components/Portal/PortalInner.tsx 100% <ø> (ø) ⬆️
...react/src/components/Provider/ProviderConsumer.tsx 100% <ø> (ø) ⬆️
packages/react/src/lib/UIComponent.tsx 82.35% <ø> (ø) ⬆️
packages/react/src/lib/createComponent.tsx 95% <ø> (ø) ⬆️
...ackages/react/src/components/Provider/Provider.tsx 93.47% <ø> (ø) ⬆️
packages/react/src/components/Design/Design.tsx 22.22% <ø> (ø) ⬆️
.../src/themes/base/components/Dialog/dialogStyles.ts 0% <ø> (ø) ⬆️
.../themes/base/components/Checkbox/checkboxStyles.ts 6.66% <0%> (+0.41%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499e78f...e38ce5d. Read the comment docs.

@layershifter
Copy link
Member Author

Status Package
🔄 fela-bindings@10.6.1
🔄 fela-dom@10.6.1
🔄 fela-plugin-custom-property@10.6.1
🔄 fela-plugin-embedded@10.6.1
🔄 fela-plugin-fallback-value@10.6.1
🔄 fela-plugin-placeholder-prefixer@10.6.1
🔄 fela-plugin-prefixer@10.6.1
🔄 fela-plugin-rtl@10.6.1
🔄 fela-tools@10.6.1
🔄 fela-utils@10.6.1
🔄 fela@10.6.1
🔄 inline-style-prefixer@5.1.0
🔄 react-fela@10.6.1
🔄 fela-plugin-expand-shorthand10.6.1
🔄 inline-style-expand-shorthand@1.1.3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up for #1741.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a uni test to document the function

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@layershifter layershifter added needs author changes Author needs to implement changes before merge and removed 🚀 ready for review labels Sep 3, 2019
@layershifter layershifter added 🚀 ready for review and removed 🗑️ chore needs author changes Author needs to implement changes before merge labels Sep 4, 2019
@layershifter layershifter force-pushed the chore/fela-switch-back branch from 29f3c4e to e38ce5d Compare September 4, 2019 16:22
@layershifter layershifter merged commit 091f282 into master Sep 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/fela-switch-back branch September 4, 2019 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS Grid is not polyfilled

3 participants