Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore(customPropTypes): remove customPropTypes.as#1775

Merged
layershifter merged 5 commits intomasterfrom
chore/remove-custom-as
Aug 16, 2019
Merged

chore(customPropTypes): remove customPropTypes.as#1775
layershifter merged 5 commits intomasterfrom
chore/remove-custom-as

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Aug 9, 2019

We don't need anymore customPropTypes.as because it exists in prop-types as PropTypes.elementType.

@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Aug 9, 2019

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in packages/react-component-nesting-registry/package.json

package before after
prop-types ^15.6.1 ^15.7.2

Changed dependencies are detected.

Changed dependencies in packages/react-component-event-listener/package.json

package before after
prop-types ^15.6.1 ^15.7.2

Changed dependencies are detected.

Changed dependencies in packages/react-proptypes/package.json

package before after
prop-types ^15.6.1 ^15.7.2

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
prop-types ^15.6.1 ^15.7.2

Changed dependencies are detected.

Changed dependencies in packages/react-component-ref/package.json

package before after
prop-types ^15.6.1 ^15.7.2

Changed dependencies are detected.

Changed dependencies in packages/docs-components/package.json

package before after
prop-types ^15.6.1 ^15.7.2

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1775 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
- Coverage   69.82%   69.82%   -0.01%     
==========================================
  Files         873      873              
  Lines        7513     7512       -1     
  Branches     2183     2210      +27     
==========================================
- Hits         5246     5245       -1     
  Misses       2259     2259              
  Partials        8        8
Impacted Files Coverage Δ
.../src/lib/accessibility/FocusZone/AutoFocusZone.tsx 100% <ø> (ø) ⬆️
...eact/src/lib/accessibility/FocusZone/FocusZone.tsx 89.65% <ø> (ø) ⬆️
.../src/lib/accessibility/FocusZone/FocusTrapZone.tsx 70.58% <ø> (ø) ⬆️
packages/react-proptypes/src/index.ts 34.26% <ø> (-0.46%) ⬇️
packages/react/src/lib/commonPropTypes.ts 100% <ø> (ø) ⬆️
...ackages/react/src/components/Provider/Provider.tsx 95.45% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f736539...d5bd34a. Read the comment docs.

…b.com/stardust-ui/react into chore/remove-custom-as

# Conflicts:
#	packages/react-proptypes/package.json
#	packages/react/package.json
#	yarn.lock
@layershifter layershifter merged commit 9439e60 into master Aug 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/remove-custom-as branch August 16, 2019 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants