This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore(Button): Adding aria-disabled when button has loading state#1789
Merged
chore(Button): Adding aria-disabled when button has loading state#1789
Conversation
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
+ Coverage 69.75% 69.76% +<.01%
==========================================
Files 868 868
Lines 7483 7484 +1
Branches 2175 2176 +1
==========================================
+ Hits 5220 5221 +1
Misses 2255 2255
Partials 8 8
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Aug 13, 2019
miroslavstastny
approved these changes
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the feedback from the users, we should set button like disabled, during button is in progress/unavailable state...