Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore: release 0.36.2#1819

Closed
layershifter wants to merge 6 commits intomasterfrom
chore/0.36.2
Closed

chore: release 0.36.2#1819
layershifter wants to merge 6 commits intomasterfrom
chore/0.36.2

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Aug 19, 2019

0.36.2

Release that contains only required features and fixes.

Changelog

layershifter and others added 5 commits August 19, 2019 13:25
* wip

* yarn.lock

* Add lodash@4.17.15 to approved dependencies

* changelog

(cherry picked from commit ab1d1a6)
* fix(Provider): use `target` in context

* wipwip

* wipwipwip

* fix UT

* remove default props

* remove one more default prop

* add changelog entry

* fixfixfix

(cherry picked from commit 11e0ba4)
* focus indicator for additional documents

* changelog

* use document.defaultView

* fix

(cherry picked from commit 6a8864a)
* wip

* wip: add onReduceItems and required wrappers directly to Toolbar

* fix build

* add overflow menu to the example

* - cancel animation frame cb on unmount

* - prettified

* Add react-resize-detector and its dependencies to approved dependencies

* changelog

(cherry picked from commit 25f8353)
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Aug 19, 2019

Warnings
⚠️ Package (or peer) dependencies changed. Make sure you have approval before merging!

Changed dependencies are detected.

Changed dependencies in packages/react-component-ref/package.json

package before after
@stardust-ui/react-proptypes ^0.36.0 ^0.36.2
prop-types ^15.7.2 ^15.6.1

Changed dependencies are detected.

Changed dependencies in packages/react-proptypes/package.json

package before after
prop-types ^15.7.2 ^15.6.1

Changed dependencies are detected.

Changed dependencies in packages/react/package.json

package before after
@stardust-ui/react-component-ref ^0.36.0 ^0.36.2
@stardust-ui/react-proptypes ^0.36.0 ^0.36.2
prop-types ^15.7.2 ^15.6.1

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #1819 into master will decrease coverage by 0.24%.
The diff coverage is 43.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1819      +/-   ##
==========================================
- Coverage   69.63%   69.38%   -0.25%     
==========================================
  Files         875      868       -7     
  Lines        7534     7421     -113     
  Branches     2220     2153      -67     
==========================================
- Hits         5246     5149      -97     
+ Misses       2280     2264      -16     
  Partials        8        8
Impacted Files Coverage Δ
packages/react/src/components/Tooltip/Tooltip.tsx 60.86% <ø> (ø) ⬆️
...hemes/teams/components/Toolbar/toolbarVariables.ts 50% <ø> (ø) ⬆️
packages/react/src/types.ts 50% <ø> (ø) ⬆️
...emes/teams/components/Toolbar/toolbarItemStyles.ts 6.25% <ø> (ø) ⬆️
...rc/themes/base/components/Toolbar/toolbarStyles.ts 25% <0%> (ø) ⬆️
packages/react/src/lib/mergeProviderContexts.ts 100% <100%> (ø) ⬆️
packages/react/src/components/Popup/Popup.tsx 65.51% <100%> (-0.41%) ⬇️
packages/react/test/utils/withProvider.tsx 100% <100%> (ø) ⬆️
...ckages/react/src/components/Portal/PortalInner.tsx 100% <100%> (ø) ⬆️
...kages/react/src/components/Toolbar/ToolbarItem.tsx 48.21% <100%> (ø) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8864a...b430aec. Read the comment docs.

@layershifter layershifter changed the title Chore/0.36.2 chore: release 0.36.2 Aug 19, 2019
@lucivpav
Copy link
Contributor

@layershifter should we merge this into master? Master currently shows v0.36.1, which is confusing because we have already released v0.36.2

@layershifter layershifter deleted the chore/0.36.2 branch August 21, 2019 10:54
@layershifter
Copy link
Member Author

I don't have a clear answer there as we definitely can't merge all commits. We can try to merge only related to release and changelog, but I don't see a big benefit there. Release process should be reviewed and improved once we will release 1.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants