Conversation
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=======================================
Coverage 67.82% 67.82%
=======================================
Files 101 101
Lines 1386 1386
Branches 265 275 +10
=======================================
Hits 940 940
Misses 443 443
Partials 3 3
Continue to review full report at Codecov.
|
| posix: undefined, // all the sibling values, but with forward slashes regardless the OS | ||
| } | ||
|
|
||
| paths.posix = _.mapValues(paths, func => (...args) => func(...args).replace(/\\/g, '/')) |
There was a problem hiding this comment.
seems that we should consider it to be a mandatory preprocessing method for provided values, so that for paths we would have POSIX ones by default:
const paths = posix({
src: ...,
dist: ...,
...
})
// and then
paths.src() // returns POSIX variant by default
// and, if it will be necessary, we can do the following (this will be about extending functionality of 'posix()')
paths.original.src()
The reason I see it being a better approach is that we will be provided with a safe defaults as a result - in contrast to the approach that is currently suggested. What do you think?
|
|
||
| task('build:docs:example-menu', () => | ||
| src(examplesSrc, { since: lastRun('build:docs:example-menu') }) | ||
| .pipe(remember('example-menu')) // FIXME: with watch this unnecessarily processes index files for all examples |
There was a problem hiding this comment.
another problem that I might see here is that if file will be removed, it will still remain to be part of the stream - and this will result in non-relevant produced result.
There was a problem hiding this comment.
There was a problem hiding this comment.
for some reason this 'unlink' event doesn't fire on my machine - seems to be an issue with 'chokidar' lib (while for 'change' events everything works). This was, essentially, the reason to ask - thanks!
kuzhelov
added
needs author feedback
kuzhelov
added
🚀 ready for review
and removed
needs author feedback
miroslavstastny
added
needs author feedback
alinais
added
ready for merge
and removed
needs author feedback
3 participants
This fixes #172:
gulp watchalways uses forward slashes regardless the OS,build:docs:example-menuremembers files, so it is run on all files when a file changes.While the
gulp.watchdocumentation clearly states that forward slashes must be used, there is no such statement forgulp.src. For now it seems that gulp.src works even with backslashes. I am not sure whether we want to change it there as well or not (make is consistent vs. don't fix anything that's not broken).