Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore: remove dependency on @stardust/proptypes in @stardust/ref#1877

Merged
layershifter merged 2 commits intomasterfrom
chore/ref
Sep 3, 2019
Merged

chore: remove dependency on @stardust/proptypes in @stardust/ref#1877
layershifter merged 2 commits intomasterfrom
chore/ref

Conversation

@layershifter
Copy link
Member

This PR removes dependency on @stardust-ui/react-proptypes in @stardust-ui/react-component-ref to get better bundle size for external consumers.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #1877 into master will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1877      +/-   ##
==========================================
- Coverage   69.74%   69.72%   -0.03%     
==========================================
  Files         885      886       +1     
  Lines        7787     7795       +8     
  Branches     2249     2283      +34     
==========================================
+ Hits         5431     5435       +4     
- Misses       2348     2350       +2     
- Partials        8       10       +2
Impacted Files Coverage Δ
packages/react-component-ref/src/toRefObject.ts 100% <ø> (ø) ⬆️
packages/react-component-ref/src/isRefObject.ts 100% <ø> (ø) ⬆️
packages/react-component-ref/src/types.ts 100% <100%> (ø)
packages/react-component-ref/src/Ref.tsx 100% <100%> (ø) ⬆️
packages/react-component-ref/src/RefFindNode.tsx 88.88% <33.33%> (-11.12%) ⬇️
packages/react-component-ref/src/RefForward.tsx 80% <33.33%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2478e2...0475294. Read the comment docs.

@layershifter layershifter merged commit a35edad into master Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/ref branch September 3, 2019 10:32
layershifter added a commit that referenced this pull request Sep 3, 2019
…-ui/react-component-ref (#1877)

(cherry picked from commit a35edad)
layershifter added a commit that referenced this pull request Sep 3, 2019
…stardust-ui/react-component-ref (#1877)"

This reverts commit 67cf18c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants