This repository was archived by the owner on Mar 4, 2020. It is now read-only.
perf: use inline-style-expand-shorthand for expanding#1925
Merged
layershifter merged 10 commits intomasterfrom Feb 26, 2020
Merged
perf: use inline-style-expand-shorthand for expanding#1925layershifter merged 10 commits intomasterfrom
inline-style-expand-shorthand for expanding#1925layershifter merged 10 commits intomasterfrom
Conversation
layershifter
changed the title
Collaborator
Changed dependencies are detected.Changed dependencies in
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
==========================================
+ Coverage 77.02% 79.12% +2.09%
==========================================
Files 158 156 -2
Lines 5459 4972 -487
Branches 1581 1479 -102
==========================================
- Hits 4205 3934 -271
+ Misses 1241 1025 -216
Partials 13 13
Continue to review full report at Codecov.
|
Member
Author
|
✅ robinweser/inline-style-expand-shorthand#11 solved |
layershifter
force-pushed
the
chore/use-fela-plugin
branch
from
960ec0f to
fe0e0bd
Compare
Contributor
|
Closing as this has seen no activity for awhile. Please reopen if still relevant. Thanks! |
layershifter
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
force-pushed
the
chore/use-fela-plugin
branch
from
b231dc4 to
4529368
Compare
layershifter
commented
Feb 11, 2020
| felaPluginEmbedded(), | ||
| felaPluginPrefixer(), | ||
|
|
||
| felaExpandCssShorthandsPlugin(), |
Member
Author
There was a problem hiding this comment.
This move is valid as inline-style-expand-shorthand handles arrays on its side.
Contributor
There was a problem hiding this comment.
How are we handling arrays exactly? As far as I can see, we are just spreading the array:
if (Array.isArray(cssPropertyValue)) {
return { ...acc, [cssPropertyName]: cssPropertyValue }
}
Is the expandProperty function handling arrays?
Member
Author
There was a problem hiding this comment.
expandProperty exactly, I added this functionality in robinweser/inline-style-expand-shorthand#13
layershifter
changed the title
inline-style-expand-shorthand for expanding
mnajdova
reviewed
Feb 26, 2020
| }) | ||
| }) | ||
|
|
||
| test('should expand handle "undefined" and "null"', () => { |
Contributor
There was a problem hiding this comment.
Can we add test for the array value scenario?
mnajdova
reviewed
Feb 26, 2020
|
|
||
| // https://jsperf.com/array-indexof-vs-object-key-lookup2/12 | ||
| const handledCssProps: Partial<Record<keyof CSS.Properties, true>> = { | ||
| // 'font', Oops, is not supported by inline-style-expand-shorthand |
Contributor
There was a problem hiding this comment.
Please add BREAKING CHANGE changelog entry
Member
Author
There was a problem hiding this comment.
Added and updated PR's description
mnajdova
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
As
inline-style-expand-shorthanddoesn't support expanding offontCSS property this probably should be done manually in styles/overrides:Before
After
This PR replaces
css-shorthand-expand(we used compiled version of it) withinline-style-expand-shorthandwhich is used infela-plugin-expand-shorthand.We cannot use
fela-plugin-expand-shorthandas it introduced regressions due merging order so I just replacedcss-shorthand-expandwhich allows us to gain 10% performance and drop complied code.🏁 Measures
Performance diff is 9.71% for the example below.
Before
After