Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(teams-theme): add proper typings#1941

Merged
mnajdova merged 1 commit intomasterfrom
fix/export-teams-theme-as-theme-prepared
Sep 17, 2019
Merged

fix(teams-theme): add proper typings#1941
mnajdova merged 1 commit intomasterfrom
fix/export-teams-theme-as-theme-prepared

Conversation

@mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Sep 17, 2019

Add typings for teams theme.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1941 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1941      +/-   ##
==========================================
+ Coverage   70.47%   70.47%   +<.01%     
==========================================
  Files         884      884              
  Lines        7796     7797       +1     
  Branches     2280     2280              
==========================================
+ Hits         5494     5495       +1     
  Misses       2291     2291              
  Partials       11       11
Impacted Files Coverage Δ
packages/react/src/themes/teams/index.tsx 91.66% <100%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bde544...ceec377. Read the comment docs.

Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to add a changelog entry for this as a fix, no?

Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just link this PR to the original work with a comment.

@mnajdova mnajdova merged commit ab9796f into master Sep 17, 2019
@mnajdova mnajdova deleted the fix/export-teams-theme-as-theme-prepared branch September 17, 2019 04:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants