This repository was archived by the owner on Mar 4, 2020. It is now read-only.
WIP: try caching component variables in theme#1982
Closed
jurokapsiar wants to merge 1 commit intoperf/custom-toolbar-perffrom
Closed
WIP: try caching component variables in theme#1982jurokapsiar wants to merge 1 commit intoperf/custom-toolbar-perffrom
jurokapsiar wants to merge 1 commit intoperf/custom-toolbar-perffrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
commented
Sep 30, 2019
| const originalSource = partStyle | ||
|
|
||
| partStylesPrepared[partName] = styleParam => { | ||
| return _.merge(callable(originalTarget)(styleParam), callable(originalSource)(styleParam)) |
Contributor
Author
There was a problem hiding this comment.
this is causing some merging of styles with null, creating unnecessary instances. the perf improvement on the custom toolbar was around 5%
Member
|
done in #2041 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like a lot of time is spent just by evaluating variables in each render. Can we instead cache the resolved component variables in the theme, only evaluate props.variables during render and deep merge them?