This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
+ Coverage 68.52% 75.57% +7.04%
==========================================
Files 910 160 -750
Lines 8306 5567 -2739
Branches 2438 1609 -829
==========================================
- Hits 5692 4207 -1485
+ Misses 2600 1346 -1254
Partials 14 14
Continue to review full report at Codecov.
|
651bb31 to
f4bd1db
Compare
jurokapsiar
approved these changes
Oct 17, 2019
miroslavstastny
approved these changes
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flexin components in internalsSimilar to #2023.
Any Stardust component will add additional style computations (merging, resolving) and will create performance degrade. One more reason to do not use
Flexes: styles ofFlexare not part of component so there is no way to generate static styles from if it used.🚀 Measures
The test example below contains the worse scenario when all previously used
Flexes will be rendered.Diff is around 39%. As
ListItemis used inDropdown, it should get performance benefits.Before
After