Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(Debug): Check that owner exists #2055

Merged
miroslavstastny merged 5 commits into from
Oct 23, 2019
Merged

fix(Debug): Check that owner exists #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83b949f
fix(Debug): Check that owner exists
miroslavstastny Oct 23, 2019
e54313f
changelog
miroslavstastny Oct 23, 2019
21c4f0e
Merge remote-tracking branch 'origin/master' into fix/debug-check-owner
miroslavstastny Oct 23, 2019
c59defb
changelog
miroslavstastny Oct 23, 2019
594ea60
fix changelog
miroslavstastny Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]

### Fixes
- Show debug panel correctly for components with no owner @miroslavstastny ([#2055](https://github.com/stardust-ui/react/pull/2055))

### Features
- Add `menu` prop on `ToolbarMenuItem` component @mnajdova ([#1984](https://github.com/stardust-ui/react/pull/1984))

Expand Down
12 changes: 7 additions & 5 deletions packages/react/src/components/Debug/DebugComponentViewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,16 @@ const style: React.CSSProperties = {
const DebugComponentViewer: React.FC<DebugComponentViewerProps> = props => {
const { fiberNav, onFiberChanged, onFiberSelected } = props

const ownerNav = fiberNav.owner
const ownerNav = fiberNav.owner || ({ jsxString: 'unknown' } as FiberNavigator)

const parentNavs = []
let parentNav = fiberNav.parent
if (fiberNav.owner) {
let parentNav = fiberNav.parent

while (parentNav && !parentNav.isEqual(ownerNav)) {
if (parentNav.stardustDebug) parentNavs.unshift(parentNav)
parentNav = parentNav.parent
while (parentNav && !parentNav.isEqual(ownerNav)) {
if (parentNav.stardustDebug) parentNavs.unshift(parentNav)
parentNav = parentNav.parent
}
}

const component = fiberNav.name && <DebugLine>{fiberNav.jsxString}</DebugLine>
Expand Down