Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(MenuButton): do not force pinned in MenuButton #2066

Merged
miroslavstastny merged 3 commits into from
Oct 30, 2019
Merged

fix(MenuButton): do not force pinned in MenuButton #2066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbc2fdc
do not force pinned in MenuButton
Oct 28, 2019
3680fac
changelog
Oct 28, 2019
12f548c
Merge remote-tracking branch 'origin/master' into fix/menubutton-pinned
miroslavstastny Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Update color scheme values in Teams theme @codepretty ([#2063](https://github.com/stardust-ui/react/pull/2063))
- Fixing a core keydown disconnect issue @dzearing ([#2056](https://github.com/stardust-ui/react/pull/2056))
- Fix blurry content of Popup @jurokapsiar ([#2067](https://github.com/stardust-ui/react/pull/2067))
- MenuButton: do not force pinned in MenuButton @jurokapsiar ([#2066](https://github.com/stardust-ui/react/pull/2066))

### Features
- Add `menu` prop on `ToolbarMenuItem` component @mnajdova ([#1984](https://github.com/stardust-ui/react/pull/1984))
Expand Down
1 change: 0 additions & 1 deletion packages/react/src/components/MenuButton/MenuButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ export default class MenuButton extends AutoControlledComponent<MenuButtonProps,
styles: styles.popupContent,
content: content && <Ref innerRef={this.menuRef}>{content}</Ref>,
},
unstable_pinned: true,
children: undefined, // force-reset `children` defined for `Popup` as it collides with the `trigger
...(contextMenu
? {
Expand Down