Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

feat(button): Adding inverted button for Teams theme#2076

Merged
notandrew merged 37 commits intomasterfrom
feat/button-inverted
Dec 20, 2019
Merged

feat(button): Adding inverted button for Teams theme#2076
notandrew merged 37 commits intomasterfrom
feat/button-inverted

Conversation

@notandrew
Copy link
Contributor

@notandrew notandrew commented Oct 30, 2019

Adding button style that inherits its background.

image

high contrast:
image

high contrast hover state (different than default button)
image

@notandrew notandrew changed the title feat(button): Adding inverted button feat(button): Adding inverted button for Teams theme Oct 30, 2019
@notandrew notandrew closed this Nov 1, 2019
@notandrew notandrew deleted the feat/button-inverted branch November 1, 2019 16:39
@notandrew notandrew restored the feat/button-inverted branch November 5, 2019 21:56
@notandrew notandrew reopened this Nov 5, 2019
@notandrew notandrew changed the title feat(button): Adding inverted button for Teams theme feat(button): Adding secondary-alternate button for Teams theme Nov 6, 2019
@microsoft microsoft deleted a comment from DustyTheBot Dec 10, 2019
@microsoft microsoft deleted a comment from DustyTheBot Dec 12, 2019
@microsoft microsoft deleted a comment from DustyTheBot Dec 12, 2019
@microsoft microsoft deleted a comment from DustyTheBot Dec 12, 2019
@DustyTheBot
Copy link
Collaborator

DustyTheBot commented Dec 16, 2019

Perf comparision

Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
Button.Fluent 1.23 0.12 10.25:1 5000 6162
Checkbox.Fluent 1.34 0.25 5.36:1 5000 6694
Icon.Fluent 0.25 0.04 6.25:1 5000 1273
Slider.Fluent 1.82 0.26 7:1 5000 9099

Generated by 🚫 dangerJS

@notandrew notandrew changed the title feat(button): Adding secondary-alternate button for Teams theme feat(button): Adding inverted button for Teams theme Dec 19, 2019
@notandrew notandrew merged commit 7841a2c into master Dec 20, 2019
@notandrew notandrew deleted the feat/button-inverted branch December 20, 2019 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants