This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(Tooltip): add usage example for Tooltip on disabled elements#2091
Merged
docs(Tooltip): add usage example for Tooltip on disabled elements#2091
Conversation
mnajdova
requested review from
dvdzkwsk,
layershifter,
levithomason and
miroslavstastny
as code owners
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
It will not work with keyboard navigation as there is nothing focusable. What it the expectation there?
@jurokapsiar can you please review?
Contributor
it's ok - by default, we don't focus disabled elements. there's inconsistency between Windows (does not allow focusing) and Office (allows focusing), we say that we should not focus disabled by default, but if justified, disabled buttons can be focusable in specific scenarios - partners can achieve that on their side (by just using |
jurokapsiar
approved these changes
Nov 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added usage example for tooltip on disabled button, for clarifying the issue: #2021