This repository was archived by the owner on Mar 4, 2020. It is now read-only.
perf: skip empty frames in mergeComponentStyles#2095
Merged
levithomason merged 20 commits intomasterfrom Nov 8, 2019
Merged
Conversation
…into perf/render-component
levithomason
requested review from
dvdzkwsk,
layershifter,
miroslavstastny and
mnajdova
as code owners
levithomason
changed the title
miroslavstastny
approved these changes
Nov 6, 2019
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
This filter should now be removed:
fluent-ui-react/packages/react/src/lib/renderComponent.tsx
Lines 276 to 278 in d9b05e0
…/react into perf/skip-empty-merge-styles
levithomason
force-pushed
the
perf/skip-empty-merge-styles
branch
from
0e481ab to
32cfc48
Compare
levithomason
added a commit
that referenced
this pull request
Nov 9, 2019
* feat(Provider): Measure rendering performance stats * wip * resolve merge conflicts * wip skip unnecessary slot/style renders * wip * fix duration counted twice * wip * restore merge themes * skip empty frames in mergeComponentStyles * cleanup cruft * remove unnecessary empty debug style check * fix renderComponent bugs * test: fix mergeThemes styles tests * fix: mergeThemes circular JSON * refactor: mergeThemes remove unnecessary code * fix: mergeThemes test * docs: update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips merging empty frames in
mergeComponentStyles. We found this to provide ~15% improvement to component render times:ChatWithPopover.perf
Skipping unnecessary merges in mergeComponentStyles