This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Merged
Conversation
miroslavstastny
commented
Nov 6, 2019
miroslavstastny
commented
Nov 6, 2019
miroslavstastny
requested review from
dvdzkwsk,
layershifter and
mnajdova
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
renderComponentresolved styles and add CSS classes for all slots in a rendered component.There are components which have a lot of slots (
ChatMessagecurrently consists of 7 slots) but not all are always used. There are even components which have mutually exclusive slots -checkboxvstoggleslots inCheckboxcomponent.In this PR, styles and CSS classes are computed only when used (that also means only IF used).
This can bring up to 10% rendering perf improvements.
Before (master):
After (this PR):