This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(menuButton) - accessibility - add aria-controls attribute, when exists#2107
Merged
fix(menuButton) - accessibility - add aria-controls attribute, when exists#2107
Conversation
kolaps33
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
kolaps33
changed the title
…ub.com/stardust-ui/react into mituron/2084-splitbutton-aria-controls
kolaps33
added
accessibility
jurokapsiar
approved these changes
Nov 13, 2019
jurokapsiar
approved these changes
Nov 13, 2019
mnajdova
reviewed
Nov 13, 2019
packages/react/test/specs/components/MenuButton/MenuButton-test.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Nov 13, 2019
mnajdova
approved these changes
Nov 13, 2019
Contributor
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Please see comments before merging
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2084