This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(SplitButton): Updating splitButton component to match Teams redlines#2108
Merged
fix(SplitButton): Updating splitButton component to match Teams redlines#2108
Conversation
notandrew
added
redlines
notandrew
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
notandrew
changed the title
notandrew
commented
Nov 19, 2019
notandrew
commented
Nov 19, 2019
packages/react/src/themes/teams/components/SplitButton/splitButtonStyles.ts
Outdated
Show resolved
Hide resolved
notandrew
requested review from
JasonGore,
dzearing,
ecraig12345,
jdhuntington and
kenotron
as code owners
silviuaavram
suggested changes
Nov 21, 2019
Collaborator
silviuaavram
left a comment
silviuaavram
left a comment
There was a problem hiding this comment.
Thank you for fixing the styles! Please take a look at the other comments as well, especially the a11y one.
docs/src/examples/components/SplitButton/Types/SplitButtonExampleSmall.shorthand.tsx
Outdated
Show resolved
Hide resolved
Collaborator
mnajdova
reviewed
Dec 17, 2019
mnajdova
reviewed
Dec 17, 2019
mnajdova
reviewed
Dec 17, 2019
mnajdova
reviewed
Dec 17, 2019
mnajdova
reviewed
Dec 17, 2019
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
Co-Authored-By: Marija Najdova <mnajdova@gmail.com>
Collaborator
|
Why did this example not get the updated caret? |
codepretty
approved these changes
Dec 19, 2019
Contributor
Author
fixed it by rotating the icon |
silviuaavram
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the split button layout to match the Teams redlines:
before:
after:
before:
after:
new:
