This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix: refactor some focus logic in MenuButton and SplitButton#2145
Merged
silviuaavram merged 5 commits intomasterfrom Dec 5, 2019
Merged
fix: refactor some focus logic in MenuButton and SplitButton#2145silviuaavram merged 5 commits intomasterfrom
silviuaavram merged 5 commits intomasterfrom
Conversation
silviuaavram
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
changed the title
kolaps33
approved these changes
Dec 5, 2019
Collaborator
kolaps33
left a comment
kolaps33
left a comment
There was a problem hiding this comment.
tested with JAWS virtual cursor and NVDA browse mode and can confirm original issue is fixed :)
silviuaavram
force-pushed
the
fix/split-button-focus
branch
from
6e319dd to
51f7bb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MenuButton: single point of changing the
openstate prop, and callingonOpenChangefrom that place.SplitButton: refactored the behavior. (Shift)Tab handlers are not needed, handled by menuButtonBehavior. Replaced the
opencall from Popup withopenAndFocusFristfrom MenuButton, in the behavior, on Alt+Arrow Down.Popup: on update/mount will check if prop
openis passed (controlled mode) and then update the trigger reference. Fixes on MenuButton the trigger focus on close when it was opened only by Arrow Down.