This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icons): Add new icons to Teams theme#2156
Merged
codepretty merged 3 commits intomasterfrom Dec 10, 2019
Merged
Conversation
codepretty
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
Technically ok.
Visually the demote is ~1px up compared to promote which can cause an icon to jump in scenarios where you switch from one to the other on click (toolbar). Is that ok?
Collaborator
Author
Good catch - will see about getting that fixed |
…ed shapes to match each other.
Contributor
|
Updated shapes and renamed presenter SVG-s.
|
miroslavstastny
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
volume-downvolumevolume-uppresenterno-presenterMicrosoft Reviewers: Open in CodeFlow