This repository was archived by the owner on Mar 4, 2020. It is now read-only.
adds publishconfig public for new packages so we don't run into publish issues#2161
Merged
adds publishconfig public for new packages so we don't run into publish issues#2161
Conversation
…s doing publishing
kenotron
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
approved these changes
Dec 10, 2019
…e ever need to publish these
ecraig12345
approved these changes
Dec 10, 2019
miroslavstastny
approved these changes
Dec 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The past failures in publishing had been related to the fact that we had new packages published to the @FluentUI scope on npmjs.org. This required a flag of
--access publicOR a publishConfig config.All the other packages within this monorepo had this config flag in package.json. I'm adding the config in the new package.json as well to prevent further issues in publishes.
Microsoft Reviewers: Open in CodeFlow