Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

chore(Perf): Add renderComponent times to perf charts#2221

Merged
miroslavstastny merged 2 commits intomasterfrom
perf/render-component-chart
Jan 13, 2020
Merged

chore(Perf): Add renderComponent times to perf charts#2221
miroslavstastny merged 2 commits intomasterfrom
perf/render-component-chart

Conversation

@miroslavstastny
Copy link
Member

Rendering performance telemetry support was added in #2079.

This PR adds rendering performance numbers to performance tests.

yarn:perf outputs them:

Example min avg median max renderComponent.min renderComponent.avg renderComponent.median renderComponent.max components
DropdownManyItems.perf.tsx 448.39 480.54 478.89 636.36 284.17 308.52 306.41 405.62 1807
DropdownMinimal.perf.tsx 5.4 15.78 6.45 34.65 3.33 9.92 4.14 21 6

yarn stats:save stores them to DB:

...
"dropdownManyItemsPerfTsx": {
  "actualTime": {
    "avg": 480.54,
    "median": 478.89,
    "min": 448.39,
    "max": 636.36
  },
  "renderComponentTime": {
    "avg": 308.52,
    "median": 306.41,
    "min": 284.17,
    "max": 405.62,
    "componentCount": 1807
  }
},
...

renderComponent times are not displayed in perf charts yet. Will be done in a separate PR.

@DustyTheBot
Copy link
Collaborator

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparison

Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🔧 Avatar.Fluent 0.58 0.37 1.57:1 2000 1159
🔧 Button.Fluent 1.27 0.18 7.06:1 1000 1274
🔧 Checkbox.Fluent 1.36 0.27 5.04:1 1000 1358
🔧 Dialog.Fluent 0.32 0.16 2:1 5000 1612
🔧 Dropdown.Fluent 3.33 0.39 8.54:1 1000 3329
🔧 Icon.Fluent 0.25 0.03 8.33:1 5000 1257
🔧 Image.Fluent 0.11 0.07 1.57:1 5000 529
🔧 Slider.Fluent 1.79 0.29 6.17:1 1000 1785
🦄 Text.Fluent 0.06 0.16 0.38:1 5000 289
🦄 Tooltip.Fluent 0.35 18.67 0.02:1 5000 1754

🔧 Needs work     🎯 On target     🦄 Amazing

Generated by 🚫 dangerJS

@miroslavstastny miroslavstastny merged commit 2e6563e into master Jan 13, 2020
@miroslavstastny miroslavstastny deleted the perf/render-component-chart branch January 13, 2020 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants