This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): check refs before focus#2248
Merged
silviuaavram merged 2 commits intomasterfrom Jan 23, 2020
Merged
Conversation
silviuaavram
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
force-pushed
the
fix/check-refs-before-focus
branch
from
7fdd2b9 to
a383b0d
Compare
silviuaavram
force-pushed
the
fix/check-refs-before-focus
branch
from
a383b0d to
088e6a5
Compare
Collaborator
Perf comparison
Generated by 🚫 dangerJS |
jurokapsiar
approved these changes
Jan 16, 2020
Contributor
jurokapsiar
left a comment
jurokapsiar
left a comment
There was a problem hiding this comment.
pls add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check inputRef and buttonRef if they exist before focusing them.