This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore(Ref): remove toRefObject() function#2287
Merged
layershifter merged 10 commits intomasterfrom Feb 3, 2020
Merged
Conversation
….com/stardust-ui/react into fix/remove-ref-object � Conflicts: � packages/react/src/components/Popup/Popup.tsx
layershifter
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
Collaborator
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
| }, []) | ||
|
|
||
| if (process.env.NODE_ENV !== 'production') { | ||
| React.useEffect(() => { |
Member
There was a problem hiding this comment.
We have a check for both being set but no propTypes/check for none. In that case you will receive a cryptic error
miroslavstastny
approved these changes
Feb 3, 2020
miroslavstastny
pushed a commit
that referenced
this pull request
Feb 3, 2020
(cherry picked from commit ec4dd3f)
miroslavstastny
pushed a commit
that referenced
this pull request
Feb 3, 2020
(cherry picked from commit ec4dd3f)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2283.
BREAKING CHANGES
toRefObject()was removed, to support previous behavior we addedtargetprop support toEventListeneranduseEventListener()hook.Before
After