This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accordion): disabled accordion title#2290
Merged
jurokapsiar merged 8 commits intomasterfrom Feb 3, 2020
Merged
Conversation
jurokapsiar
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
added 2 commits
January 30, 2020 07:09
added 2 commits
January 31, 2020 09:42
Collaborator
Perf comparison
Perf tests with no regressions
Generated by 🚫 dangerJS |
mnajdova
reviewed
Jan 31, 2020
packages/accessibility/src/behaviors/Accordion/accordionTitleBehavior.ts
Show resolved
Hide resolved
packages/accessibility/src/behaviors/Accordion/accordionTitleBehavior.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 31, 2020
mnajdova
reviewed
Jan 31, 2020
packages/accessibility/src/behaviors/Accordion/accordionTitleBehavior.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jan 31, 2020
packages/react/test/specs/components/Accordion/Accordion-test.tsx
Outdated
Show resolved
Hide resolved
mnajdova
approved these changes
Jan 31, 2020
Contributor
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Looks good, please see comments before merging
packages/react/src/themes/teams/components/Accordion/accordionTitleStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Accordion/accordionTitleStyles.ts
Outdated
Show resolved
Hide resolved
packages/react/test/specs/components/Accordion/Accordion-test.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Jan 31, 2020
added 2 commits
February 3, 2020 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow disabling accordion titles so that they can be present, but won't allow the user to expand the content