This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusZone): Cleanup DOM element references on unmount#2304
Closed
johannao76 wants to merge 4 commits intomicrosoft:masterfrom
Closed
fix(FocusZone): Cleanup DOM element references on unmount#2304johannao76 wants to merge 4 commits intomicrosoft:masterfrom
johannao76 wants to merge 4 commits intomicrosoft:masterfrom
Conversation
…unted The FocusZone component holds references to _activeElement and _defaultFocusElement. These references should be nulled out when the component is unmounted to prevent memory leaks. closes microsoft#2303
johannao76
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Collaborator
Perf comparison
Generated by 🚫 dangerJS |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FocusZone component holds references to _activeElement and _defaultFocusElement. These references should be nulled out when the component is unmounted to prevent memory leaks.
Fixes #2303