This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore(DropdownItem): refactor to functional component with hooks#2382
Merged
silviuaavram merged 6 commits intomasterfrom Feb 25, 2020
Merged
chore(DropdownItem): refactor to functional component with hooks#2382silviuaavram merged 6 commits intomasterfrom
silviuaavram merged 6 commits intomasterfrom
Conversation
silviuaavram
requested review from
JasonGore,
dvdzkwsk,
dzearing,
ecraig12345,
jdhuntington,
kenotron,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Collaborator
Perf comparison
Potential regressions comparing to master
Perf tests with no regressions
Generated by 🚫 dangerJS |
Member
|
Looks good 👍 Can you please merge |
silviuaavram
force-pushed
the
chore/dropdown-item-functional-component
branch
from
99f2e5a to
fb57c55
Compare
silviuaavram
force-pushed
the
chore/dropdown-item-functional-component
branch
from
fb57c55 to
0f10ca2
Compare
mnajdova
approved these changes
Feb 25, 2020
Contributor
mnajdova
left a comment
mnajdova
left a comment
There was a problem hiding this comment.
Looks good, please add changelog entry with breaking change, and add in the PR description which props are now passed to the styles function
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired heavily by
ListItem. Removed the use ofListItemand created the slots similarly to howListItemdoes it. Also added somelistItemStylestodropdownItemStylesin order to compensate from not usingListItemanymore.BREAKING CHANGES
Only limited amount of props are passed to component's styles functions.
DropdownItemactiveisFromKeyboardselectedhasContenthasHeader