docs: update theming styles section#274
Conversation
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
changed the title
styles sectionstyles section
levithomason
force-pushed
the
docs/theming
branch
from
1b457cf to
5667314
Compare
| You can customize all components in your app by defining component variables on a Provider at | ||
| the root of your app. | ||
| You can customize component variables for your entire app by defining component variables on a{' '} | ||
| <NavLink to="components/provider">Provider</NavLink> at the root of your app. |
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 92.36% 92.19% -0.17%
==========================================
Files 63 61 -2
Lines 1152 1127 -25
Branches 152 168 +16
==========================================
- Hits 1064 1039 -25
Misses 84 84
Partials 4 4
Continue to review full report at Codecov.
|
| value={[ | ||
| `<Button`, | ||
| ` icon={{ name: "user", styles: { borderBottom: '4px solid red' } }}`, | ||
| ` icon={{ name: 'user', styles: { boxShadow: '0 0 0 2px red' } }}`, |
There was a problem hiding this comment.
very representative both logically and visually 👍
docs/src/views/Theming.tsx
Outdated
| /> | ||
| <p> | ||
| Every slot (named part) of every component also accepts <code>styles</code> that are applied | ||
| to the root of the slot. |
There was a problem hiding this comment.
Indeed, updating...
| </div> | ||
| )} | ||
| /> | ||
| <p> |
There was a problem hiding this comment.
just as a side notice - currently there are no links to the next (if necessary, as there are components sections coming next) and (surely) previous docs page - the ones that are present for the rest of the docs pages. Most probably you already have a plan to address that
2 participants
This PR updates the theming guide:
stylesinfo to match the flow and pacing of thevariablessection:stylesprop on the rootstylesprop on a named slotProviderProviderBefore
After