This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(list): enter and spacebar keyboard handling for List and Listitem#279
Merged
jurokapsiar merged 11 commits intomasterfrom Dec 20, 2018
Merged
feat(list): enter and spacebar keyboard handling for List and Listitem#279jurokapsiar merged 11 commits intomasterfrom
jurokapsiar merged 11 commits intomasterfrom
Conversation
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
jurokapsiar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
========================================
+ Coverage 87.96% 89% +1.03%
========================================
Files 42 41 -1
Lines 1404 1391 -13
Branches 183 202 +19
========================================
+ Hits 1235 1238 +3
+ Misses 165 149 -16
Partials 4 4
Continue to review full report at Codecov.
|
tomasiser
reviewed
Sep 26, 2018
src/lib/accessibility/Behaviors/List/SelectableListItemBehavior.ts
Outdated
Show resolved
Hide resolved
bmdalex
reviewed
Sep 26, 2018
kuzhelov
changed the title
Collaborator
|
When I tried to navigate into the list with Figure out that it causing the role='presentation' which is generated on the div about the list. Find out if JAWS user navigate to listbox with virtual cursor, then need to press space activate navigation in listbox: |
jurokapsiar
changed the title
sophieH29
approved these changes
Nov 8, 2018
layershifter
approved these changes
Dec 20, 2018
Member
layershifter
left a comment
layershifter
left a comment
There was a problem hiding this comment.
Left some NITs, we need to resolve merge conflicts there and ship it 👍
Collaborator
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds focus zone and Enter/Space keyboard handlers to selection list.