This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(provider): fix for rendering components outside provider#378
Merged
fix(provider): fix for rendering components outside provider#378
Conversation
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
fix/provider-render-outside
branch
from
72b6b29 to
8e9a7c3
Compare
kuzhelov
reviewed
Oct 19, 2018
kuzhelov
reviewed
Oct 19, 2018
Member
|
@Bugaa92 Note, if you slightly adjust the PR description then this PR will automatically close the associated issue once it is merged. See here: https://help.github.com/articles/closing-issues-using-keywords/ |
bmdalex
force-pushed
the
fix/provider-render-outside
branch
5 times, most recently
from
8914414 to
b24749d
Compare
levithomason
added
needs author changes
bmdalex
force-pushed
the
fix/provider-render-outside
branch
from
b24749d to
131e186
Compare
bmdalex
added
🚀 ready for review
and removed
needs author changes
Collaborator
Author
|
@levithomason comments were addressed |
bmdalex
force-pushed
the
fix/provider-render-outside
branch
from
131e186 to
e3c82f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 41 41
Lines 1340 1340
Branches 172 172
=======================================
Hits 1229 1229
Misses 107 107
Partials 4 4Continue to review full report at Codecov.
|
bmdalex
force-pushed
the
fix/provider-render-outside
branch
2 times, most recently
from
a0cc99a to
a132154
Compare
bmdalex
force-pushed
the
fix/provider-render-outside
branch
from
a132154 to
fa38e5d
Compare
kuzhelov
approved these changes
Oct 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider
This PR is a fix proposal that closes #372.
TODO
Proposed solution
Meaningful console error with link pointing to documentation where user can find examples of correct usage:
