This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs: add transparent button to examples#407
Merged
levithomason merged 2 commits intomasterfrom Oct 29, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 41 41
Lines 1341 1341
Branches 172 197 +25
=======================================
Hits 1230 1230
Misses 107 107
Partials 4 4Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Oct 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected
The Segment should have a background color to appear solid.
Actual
The segment only has a border and shadow 😞
Problem
This was never noticed because the example card includes a background color:
Fix
The docs now include a "Transparent" button on each example. We should use this liberally when designing components.
Toggling the example to transparent mode clearly shows the issue: