This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(components): create component implementation#472
Merged
Conversation
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
feat/create-component
branch
from
98efc24 to
ca84b36
Compare
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 88.96% 88.94% -0.03%
==========================================
Files 41 41
Lines 1387 1384 -3
Branches 202 202
==========================================
- Hits 1234 1231 -3
Misses 149 149
Partials 4 4
Continue to review full report at Codecov.
|
levithomason
approved these changes
Nov 14, 2018
bmdalex
force-pushed
the
feat/create-component
branch
from
88cc6b1 to
db764e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create component
Description
This PR introduces:
createComponentfactory method for creating custom Stardust components (having all Stardust capabilities)Slotcomponent to usecreateComponentTODO
propTypesBlockers:
feat(utils): replace react-docgen with typescript feat(utils): replace react-docgen with typescript #460