This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(ChatPane): Add attachments and link to chat pane messages in prototype#514
Merged
docs(ChatPane): Add attachments and link to chat pane messages in prototype#514
Conversation
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 42 42
Lines 1455 1455
Branches 212 212
=======================================
Hits 1283 1283
Misses 167 167
Partials 5 5Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Nov 22, 2018
layershifter
approved these changes
Nov 26, 2018
Member
layershifter
left a comment
There was a problem hiding this comment.
Left one small note, LGTM
Collaborator
Generated by 🚫 dangerJS |
mnajdova
reviewed
Nov 26, 2018
Contributor
mnajdova
left a comment
There was a problem hiding this comment.
The changes looks good, have tested it locally and it is behaving as in the description. However, it is a bit overwhelming for all messages to have attachments. Can you at least add the attachments on every 5th message let's say? Will approve after this change. No other changes required from my side.
mnajdova
approved these changes
Nov 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve chat pane behavior by adding Attachments and links to chat message so provide the proper accessibility experience for it.
Opened context menu:
