This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(Editor): fix broken HTML preview when Provider.Consumer was used#555
Merged
layershifter merged 5 commits intomasterfrom Dec 4, 2018
Merged
fix(Editor): fix broken HTML preview when Provider.Consumer was used#555layershifter merged 5 commits intomasterfrom
layershifter merged 5 commits intomasterfrom
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
…x/editor-html # Conflicts: # CHANGELOG.md
kuzhelov
reviewed
Dec 4, 2018
mnajdova
reviewed
Dec 4, 2018
| <SourceRender.Consumer>{({ element }) => element}</SourceRender.Consumer> | ||
| </Provider> | ||
| ) | ||
| return <Provider theme={newTheme}>{element}</Provider> |
Contributor
There was a problem hiding this comment.
Is this always invoked with the result from renderExampleWithCode()? Not sure whether we want to remove the consumer from here.
Member
Author
There was a problem hiding this comment.
Nope, it will called with the result of rendering i.e. an element from ButtonExample. This result will be will wrapped with our Provider and then will be passed to renderExampleFromCode(). It's quite similar to render* props that we had before.
Contributor
There was a problem hiding this comment.
Got it, thanks for the clarification.
mnajdova
reviewed
Dec 4, 2018
| "react-router": "^4.1.2", | ||
| "react-router-dom": "^4.1.2", | ||
| "react-source-render": "^2.0.0-beta.3", | ||
| "react-source-render": "^2.0.0-beta.4", |
Contributor
There was a problem hiding this comment.
Why we needed this change?
Member
Author
There was a problem hiding this comment.
Because the render prop was introduced in this version of the package.
kuzhelov
approved these changes
Dec 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes broken HTML preview for examples that using
Provider.Consumer, it happens becauserenderToStaticMarkup()was done withoutProvider.