This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Closed
Conversation
smykhailov
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
mnajdova
as code owners
levithomason
reviewed
Aug 7, 2018
| public static rules = buttonRules | ||
|
|
||
| public static variables = buttonVariables | ||
| public static variables: (x) => IButtonVariables = buttonVariables |
Member
There was a problem hiding this comment.
I have removed all static rules and variables in #16. We're breaking that PR down into several smaller PRs, however, there will be no more static rules/variables in any components moving forward.
levithomason
reviewed
Aug 7, 2018
| props: { atMention, disabled, error, size, important, success, timestamp, truncated }, | ||
| variables: v, | ||
| }: TextRulesParams) => ({ | ||
| }: any) => ({ |
Member
There was a problem hiding this comment.
This is also changed in #16, there will be a break out PR that introduces proper baseline typings for styles.
levithomason
reviewed
Aug 7, 2018
| export const felaRenderer = createRenderer(createRendererConfig()) | ||
| export const felaRtlRenderer = createRenderer(createRendererConfig({ isRtl: true })) | ||
| export const felaRenderer: IRenderer = createRenderer(createRendererConfig()) | ||
| export const felaRtlRenderer: IRenderer = createRenderer(createRendererConfig({ isRtl: true })) |
Member
There was a problem hiding this comment.
This is also a change that has been implemented in #16 while updating typings.
levithomason
suggested changes
Aug 7, 2018
Collaborator
Author
|
Agree, let me close this PR and wait for #16 to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've realized that TypeScript compiler generates wrong import paths for some of the types: rules and variables. This happens because we use implicit import for static properties and compiler inlines import statements.
To avoid this, we have to explicitly specify the type of the rules and/or variables or remove typing for such properties, if it is more appropriate.