This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Closed
Conversation
kuzhelov
requested review from
dvdzkwsk,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Collaborator
Generated by 🚫 dangerJS |
Contributor
Author
|
closing as there is a cleaner fix PR () introduced for this problem: #579 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: ongoing work..
Working state is achieved now, with the code of playground quality
The cause of the problem is the fact that Fela was not able to define
rtl-*classes in the<head>'s<style>element with previous rendering technique (while thesertl-*class names were applied to rendered DOM elements).Currently have distilled everything to key bits of the rendering process - with the fix we should remove all the unnecessary indirection in the code rendering logic.