Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(MenuItem): "onFocus" is not handled as prop #677

Merged
sophieH29 merged 2 commits into from
Jan 3, 2019
Merged

fix(MenuItem): "onFocus" is not handled as prop #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
badea36
fix(MenuItem): "onFocus" is not handled as prop
Jan 3, 2019
1662410
update changelog
Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
- Fix `defaultOpen` prop in the `Popup` component @mnajdova ([#659](https://github.com/stardust-ui/react/pull/659))
- Fix `Chat` - added themes values for dark and contrast @bcalvery ([#652](https://github.com/stardust-ui/react/pull/652))
- Fix compatibility with TypeScript 3.2 and handle `null` as a valid value in all optional props @layershifter ([#550](https://github.com/stardust-ui/react/pull/550))
- Fix `MenuItem` - `onFocus` is not handled as prop @sophieH29 ([#677](https://github.com/stardust-ui/react/pull/677))

### Features
- Add `color` prop to `Text` component @Bugaa92 ([#597](https://github.com/stardust-ui/react/pull/597))
Expand Down
6 changes: 3 additions & 3 deletions src/components/Menu/MenuItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,11 @@ export interface MenuItemProps
onClick?: ComponentEventHandler<MenuItemProps>

/**
* Called on key down pressed.
*
* Called after user's focus.
* @param {SyntheticEvent} event - React's original SyntheticEvent.
* @param {object} data - All props.
*/
onKeyDown?: ComponentEventHandler<MenuItemProps>
Copy link
Contributor Author

@sophieH29 sophieH29 Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not used

onFocus?: ComponentEventHandler<MenuItemProps>

/** A menu can adjust its appearance to de-emphasize its contents. */
pills?: boolean
Expand Down Expand Up @@ -132,6 +131,7 @@ class MenuItem extends AutoControlledComponent<ReactProps<MenuItemProps>, MenuIt
iconOnly: PropTypes.bool,
index: PropTypes.number,
onClick: PropTypes.func,
onFocus: PropTypes.func,
pills: PropTypes.bool,
pointing: PropTypes.oneOfType([PropTypes.bool, PropTypes.oneOf(['start', 'end'])]),
primary: customPropTypes.every([customPropTypes.disallow(['secondary']), PropTypes.bool]),
Expand Down