Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(acc): Remove popup trigger button role #806

Merged
jurokapsiar merged 2 commits into from
Jan 31, 2019
Merged

fix(acc): Remove popup trigger button role #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cae90a2
remove popup trigger button role
jurokapsiar Jan 30, 2019
43bd080
changelog
Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Fixes
- Handle `onClick` and `onFocus` on ListItems correctly @layershifter ([#779](https://github.com/stardust-ui/react/pull/779))
- Remove popup trigger button default role @jurokapsiar ([#806](https://github.com/stardust-ui/react/pull/806))

<!--------------------------------[ v0.19.1 ]------------------------------- -->
## [v0.19.1](https://github.com/stardust-ui/react/tree/v0.19.1) (2019-01-29)
Expand Down
2 changes: 0 additions & 2 deletions src/lib/accessibility/Behaviors/Popup/popupBehavior.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import * as _ from 'lodash'

/**
* @description
* Adds role='button' to 'trigger' component's part, if it is not focusable element and no role attribute provided.
* Adds tabIndex='0' to 'trigger' component's part, if it is not tabbable element and no tabIndex attribute provided.
*
* @specification
Expand All @@ -14,7 +13,6 @@ const popupBehavior: Accessibility = (props: any) => {
return {
attributes: {
trigger: {
role: getAriaAttributeFromProps('role', props, 'button'),
tabIndex: getAriaAttributeFromProps('tabIndex', props, '0'),
'aria-disabled': !_.isNil(props['aria-disabled'])
? props['aria-disabled']
Expand Down