This repository was archived by the owner on Mar 4, 2020. It is now read-only.
docs(screener-io): added documentation on how to write tests with steps#856
Merged
silviuaavram merged 7 commits intomasterfrom Feb 8, 2019
Merged
docs(screener-io): added documentation on how to write tests with steps#856silviuaavram merged 7 commits intomasterfrom
silviuaavram merged 7 commits intomasterfrom
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #856 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 69 73 +4
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
mnajdova
reviewed
Feb 7, 2019
mnajdova
reviewed
Feb 7, 2019
sophieH29
reviewed
Feb 7, 2019
bmdalex
approved these changes
Feb 7, 2019
Collaborator
bmdalex
left a comment
bmdalex
left a comment
There was a problem hiding this comment.
GG 👍 thanks @silviuavram
kuzhelov
reviewed
Feb 7, 2019
layershifter
reviewed
Feb 8, 2019
| - tests do not perform any cleanup by default. This means a test is dependent on the state of the component in which the previous test leaves it. In the example above, the second test will receive the `Dropdown` component with the list open. | ||
|
|
||
| ### Run Screener tests | ||
| In order to run the tests locally, make sure to have a Screener API key saved in the environment variables on your machine. For instance, on MacOS/Linux you can use `export SCREENER_API_KEY=<Your screener key here>`. |
Member
There was a problem hiding this comment.
And what is for Windows? 🔍
This should work:
cross-env SCREENER_API_KEY=<Your screener key here> yarn test:visual
Collaborator
Author
There was a problem hiding this comment.
oups. will address this in my arrow navigation PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation on how to write tests with the Screener Steps.
At the moment I added a draft change, and I think I can have some feedback while I also look to improve it.