This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Closed
Conversation
priyankar205
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
==========================================
+ Coverage 80.58% 80.61% +0.02%
==========================================
Files 649 651 +2
Lines 8320 8332 +12
Branches 1484 1420 -64
==========================================
+ Hits 6705 6717 +12
Misses 1600 1600
Partials 15 15
Continue to review full report at Codecov.
|
Collaborator
|
The lock with keyhole is a deprecated design for Teams theme. Please use the icons-lock from the ProcessedIcons folder. |
kuzhelov
reviewed
Feb 11, 2019
| - Add `black` and `white` options for the `color` prop of the `Label` component @mnajdova ([#855](https://github.com/stardust-ui/react/pull/855)) | ||
| - Add `Flex` component @kuzhelov ([#802](https://github.com/stardust-ui/react/pull/802)) | ||
| - Add `inline` prop for `Dropdown` component @Bugaa92 ([#863](https://github.com/stardust-ui/react/pull/863)) | ||
| - Export `lock-new` SVG icon @priyankar205 ([#872](https://github.com/stardust-ui/react/pull/872)) |
Contributor
There was a problem hiding this comment.
would like @codepretty to take a look on this PR before merge
kuzhelov
suggested changes
Feb 11, 2019
Contributor
kuzhelov
left a comment
kuzhelov
left a comment
There was a problem hiding this comment.
is waiting for resolution from design team
Contributor
|
@priyankar205 , @codepretty I believe that this PR doesn't make sense after the merge of #906, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.