This repository was archived by the owner on Mar 4, 2020. It is now read-only.
proto(dropdown): @mention scenario#901
Closed
bmdalex wants to merge 1 commit intofeat/dropdown-open-propfrom
Closed
proto(dropdown): @mention scenario#901bmdalex wants to merge 1 commit intofeat/dropdown-open-propfrom
bmdalex wants to merge 1 commit intofeat/dropdown-open-propfrom
Conversation
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
Collaborator
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## feat/dropdown-open-prop #901 +/- ##
==========================================================
- Coverage 80.6% 80.6% -0.01%
==========================================================
Files 649 649
Lines 8318 8317 -1
Branches 1420 1420
==========================================================
- Hits 6705 6704 -1
Misses 1598 1598
Partials 15 15
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## feat/dropdown-open-prop #901 +/- ##
===========================================================
- Coverage 80.38% 80.38% -0.01%
===========================================================
Files 656 656
Lines 8392 8391 -1
Branches 1424 1424
===========================================================
- Hits 6746 6745 -1
Misses 1631 1631
Partials 15 15
Continue to review full report at Codecov.
|
bmdalex
force-pushed
the
feat/dropdown-open-prop
branch
2 times, most recently
from
07b3939 to
161ab7d
Compare
bmdalex
force-pushed
the
proto/dropdown-with-atmentions-simple
branch
from
0425964 to
b459d6d
Compare
bmdalex
force-pushed
the
proto/dropdown-with-atmentions-simple
branch
from
b459d6d to
4d55c7b
Compare
Collaborator
Author
|
opened this PR agains wrong branch, moved to #931 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto(dropdown): @mention scenario
Description
This PR attempts to create a prototype to show users how they can mention people using
@key in a rich text editor.I am using a
contentEditablediv as rich text input and theDropdowncomponent to leverage the list of users and filtering through them. The rest of the functionality is in the prototype sectionScreenshot
Issues:
createPortalinstead of mounting another element proto(dropdown): @mention scenario #901 (comment)