This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore(dangerjs): add check for a changelog entry#918
Merged
layershifter merged 4 commits intomasterfrom Feb 19, 2019
Merged
Conversation
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
=======================================
Coverage 80.57% 80.57%
=======================================
Files 651 651
Lines 8330 8330
Branches 1484 1420 -64
=======================================
Hits 6712 6712
Misses 1603 1603
Partials 15 15Continue to review full report at Codecov.
|
miroslavstastny
approved these changes
Feb 18, 2019
dangerfile.ts
Outdated
Member
There was a problem hiding this comment.
This seems to be too fragile. Adding or removing a single - will break if without being ever noticed.
I would rather search for the second <!--.
Member
|
Tested on #858 which has the real changelog issue, successfully caught! 👍 |
layershifter
force-pushed
the
chore/danger-changelog
branch
from
db64f6d to
6f43fb5
Compare
layershifter
force-pushed
the
chore/danger-changelog
branch
from
6f43fb5 to
7f9166e
Compare
layershifter
commented
Feb 18, 2019
|
|
||
| ### Fixes | ||
| - Display correctly images in portrait mode inside `Avatar` @layershifter ([#899](https://github.com/stardust-ui/react/pull/899)) | ||
| - Expose `Popup`'s content Ref @sophieH29 ([#913](https://github.com/stardust-ui/react/pull/913)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new function to our
dangerfilethat checks that changelog entries are added to the correct section.